Tijden veranderen
Verwijderen van upload werkt onbetrouwbaar
Maar het is al een paar keer gebeurd dat hij een file niet goed verwijderd heeft. Vanochtend was een jpg-file wel uit directory verwijderd, maar niet uit de database bijvoorbeeld.
Met "php_flag display_errors On" krijg ik geen foutmeldingen.
Wat doe ik fout in het volgende stukje code?
Code (php)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
<?php
if($_SERVER['REQUEST_METHOD'] == "POST") {
if(!empty($_POST['delete'])) {
/* STAP 1 = bestand uit directory verwijderen */
$file_src = $_SERVER['DOCUMENT_ROOT'] . "/upload/" . $_POST['nieuwnaam'];
if (file_exists($file_src)) {
$file_verwijderen = unlink($file_src);
echo $file_verwijderen;
if ($file_verwijderen) {
/* STAP 2 = file-gegevens uit database verwijderen */
$i = 0;
$ii = 0;
foreach($_POST['delete'] as $id) {
$bQuery = "DELETE FROM uploads WHERE id = '" . mysql_real_escape_string($id) . "'";
$resultaat = mysql_query($bQuery, $db_connect)
or die("Ongeldige query: " . mysql_error());
if($resultaat && (mysql_affected_rows() == 1)) {
$i++;
}
else {
$ii++;
}
}
if ($resultaat) {
echo " - " . "Bijdrage nummer <b>" . $id . "</b> is verwijderd.</br />";
}
}
}
}
echo "<p>De database is geupdate, er zijn " . $i . " records goed verwijderd en " . $ii . " mislukt!</p>";
}
?>
if($_SERVER['REQUEST_METHOD'] == "POST") {
if(!empty($_POST['delete'])) {
/* STAP 1 = bestand uit directory verwijderen */
$file_src = $_SERVER['DOCUMENT_ROOT'] . "/upload/" . $_POST['nieuwnaam'];
if (file_exists($file_src)) {
$file_verwijderen = unlink($file_src);
echo $file_verwijderen;
if ($file_verwijderen) {
/* STAP 2 = file-gegevens uit database verwijderen */
$i = 0;
$ii = 0;
foreach($_POST['delete'] as $id) {
$bQuery = "DELETE FROM uploads WHERE id = '" . mysql_real_escape_string($id) . "'";
$resultaat = mysql_query($bQuery, $db_connect)
or die("Ongeldige query: " . mysql_error());
if($resultaat && (mysql_affected_rows() == 1)) {
$i++;
}
else {
$ii++;
}
}
if ($resultaat) {
echo " - " . "Bijdrage nummer <b>" . $id . "</b> is verwijderd.</br />";
}
}
}
}
echo "<p>De database is geupdate, er zijn " . $i . " records goed verwijderd en " . $ii . " mislukt!</p>";
}
?>
En $ii wordt verhoogd als er niets is geupdate maar ook als de query is mislukt. Je weet dus niet exact om welke reden $ii is verhoogd.
Zo werkt het ook (en hopelijk nu foutloos),
Code (php)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
<?php
if($_SERVER['REQUEST_METHOD'] == "POST" && !empty($_POST['delete'])) {
/* STAP 1 = bestand uit directory verwijderen */
$file_src = $_SERVER['DOCUMENT_ROOT'] . "/upload/" . $_POST['nieuwnaam'];
if (file_exists($file_src)) {
$file_verwijderen = unlink($file_src);
echo $file_verwijderen;
if ($file_verwijderen) {
/* STAP 2 = file-gegevens uit database verwijderen */
foreach($_POST['delete'] as $id) {
$bQuery = "DELETE FROM uploads WHERE id = '" . mysql_real_escape_string($id) . "'";
$resultaat = mysql_query($bQuery, $db_connect);
}
}
}
echo "<p>De file is verwijderd!</p>";
}
?>
if($_SERVER['REQUEST_METHOD'] == "POST" && !empty($_POST['delete'])) {
/* STAP 1 = bestand uit directory verwijderen */
$file_src = $_SERVER['DOCUMENT_ROOT'] . "/upload/" . $_POST['nieuwnaam'];
if (file_exists($file_src)) {
$file_verwijderen = unlink($file_src);
echo $file_verwijderen;
if ($file_verwijderen) {
/* STAP 2 = file-gegevens uit database verwijderen */
foreach($_POST['delete'] as $id) {
$bQuery = "DELETE FROM uploads WHERE id = '" . mysql_real_escape_string($id) . "'";
$resultaat = mysql_query($bQuery, $db_connect);
}
}
}
echo "<p>De file is verwijderd!</p>";
}
?>
Het gehele formulier om te uploaden is als volgt,
Code (php)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
<?php
// controleren of pagina zichzelf heeft aangeroepen
if ($_SERVER['REQUEST_METHOD'] == 'POST') {
// begin de controles
if ($_FILES['upload']['error'] > 0) {
// niet goed verzonden of pagina is foutief aangeroepen
echo "Er is geen bestand geselecteerd om te uploaden!<br />";
// ga een pagina terug
if (isset($_SERVER['REQUEST_URI'])) {
echo "<br />Probeer het <a href=\"" . $_SERVER['REQUEST_URI'] . "\">nogmaals</a>";
}
exit;
}
else {
// een array maken met alle waarden voor de foto
$files = $_FILES['upload'];
}
$type = array(
"ez" => "application/andrew-inset",
"hqx" => "application/mac-binhex40",
"cpt" => "application/mac-compactpro",
"doc" => "application/msword",
"bin" => "application/octet-stream",
"dms" => "application/octet-stream",
"lha" => "application/octet-stream",
"lzh" => "application/octet-stream",
"exe" => "application/octet-stream",
"class" => "application/octet-stream",
"so" => "application/octet-stream",
"dll" => "application/octet-stream",
"oda" => "application/oda",
"pdf" => "application/pdf",
"ai" => "application/postscript",
"eps" => "application/postscript",
"ps" => "application/postscript",
"smi" => "application/smil",
"smil" => "application/smil",
"wbxml" => "application/vnd.wap.wbxml",
"wmlc" => "application/vnd.wap.wmlc",
"wmlsc" => "application/vnd.wap.wmlscriptc",
"bcpio" => "application/x-bcpio",
"vcd" => "application/x-cdlink",
"pgn" => "application/x-chess-pgn",
"cpio" => "application/x-cpio",
"csh" => "application/x-csh",
"dcr" => "application/x-director",
"dir" => "application/x-director",
"dxr" => "application/x-director",
"dvi" => "application/x-dvi",
"spl" => "application/x-futuresplash",
"gtar" => "application/x-gtar",
"hdf" => "application/x-hdf",
"js" => "application/x-javascript",
"skp" => "application/x-koan",
"skd" => "application/x-koan",
"skt" => "application/x-koan",
"skm" => "application/x-koan",
"latex" => "application/x-latex",
"nc" => "application/x-netcdf",
"cdf" => "application/x-netcdf",
"sh" => "application/x-sh",
"shar" => "application/x-shar",
"swf" => "application/x-shockwave-flash",
"sit" => "application/x-stuffit",
"sv4cpio" => "application/x-sv4cpio",
"sv4crc" => "application/x-sv4crc",
"tar" => "application/x-tar",
"tcl" => "application/x-tcl",
"tex" => "application/x-tex",
"texinfo" => "application/x-texinfo",
"texi" => "application/x-texinfo",
"t" => "application/x-troff",
"tr" => "application/x-troff",
"roff" => "application/x-troff",
"man" => "application/x-troff-man",
"me" => "application/x-troff-me",
"ms" => "application/x-troff-ms",
"ustar" => "application/x-ustar",
"src" => "application/x-wais-source",
"xhtml" => "application/xhtml+xml",
"xht" => "application/xhtml+xml",
"zip" => "application/zip",
"au" => "audio/basic",
"snd" => "audio/basic",
"mid" => "audio/midi",
"midi" => "audio/midi",
"kar" => "audio/midi",
"mpga" => "audio/mpeg",
"mp2" => "audio/mpeg",
"mp3" => "audio/mpeg",
"aif" => "audio/x-aiff",
"aiff" => "audio/x-aiff",
"aifc" => "audio/x-aiff",
"m3u" => "audio/x-mpegurl",
"ram" => "audio/x-pn-realaudio",
"rm" => "audio/x-pn-realaudio",
"rpm" => "audio/x-pn-realaudio-plugin",
"ra" => "audio/x-realaudio",
"wav" => "audio/x-wav",
"pdb" => "chemical/x-pdb",
"xyz" => "chemical/x-xyz",
"bmp" => "image/bmp",
"gif" => "image/gif",
"ief" => "image/ief",
"jpeg" => "image/jpeg",
"jpg" => "image/jpeg",
"jpe" => "image/jpeg",
"png" => "image/png",
"tiff" => "image/tiff",
"tif" => "image/tif",
"djvu" => "image/vnd.djvu",
"djv" => "image/vnd.djvu",
"wbmp" => "image/vnd.wap.wbmp",
"ras" => "image/x-cmu-raster",
"pnm" => "image/x-portable-anymap",
"pbm" => "image/x-portable-bitmap",
"pgm" => "image/x-portable-graymap",
"ppm" => "image/x-portable-pixmap",
"rgb" => "image/x-rgb",
"xbm" => "image/x-xbitmap",
"xpm" => "image/x-xpixmap",
"xwd" => "image/x-windowdump",
"igs" => "model/iges",
"iges" => "model/iges",
"msh" => "model/mesh",
"mesh" => "model/mesh",
"silo" => "model/mesh",
"wrl" => "model/vrml",
"vrml" => "model/vrml",
"css" => "text/css",
"html" => "text/html",
"htm" => "text/html",
"asc" => "text/plain",
"txt" => "text/plain",
"rtx" => "text/richtext",
"rtf" => "text/rtf",
"sgml" => "text/sgml",
"sgm" => "text/sgml",
"tsv" => "text/tab-seperated-values",
"wml" => "text/vnd.wap.wml",
"wmls" => "text/vnd.wap.wmlscript",
"etx" => "text/x-setext",
"xml" => "text/xml",
"xsl" => "text/xml",
"mpeg" => "video/mpeg",
"mpg" => "video/mpeg",
"mpe" => "video/mpeg",
"qt" => "video/quicktime",
"mov" => "video/quicktime",
"mxu" => "video/vnd.mpegurl",
"avi" => "video/x-msvideo",
"movie" => "video/x-sgi-movie",
"ice" => "x-conference-xcooltalk"
);
$ext = strtolower(substr(strrchr($files['name'],"."),1));
if(!in_array($ext,$type)) {
$soort = $type[$ext];
}
else {
$soort = "unknown";
}
$map = '/upload/';
$naam = mktime() . "." . $ext;
if (!move_uploaded_file($files['tmp_name'], $_SERVER['DOCUMENT_ROOT'] . $map . $naam)) {
$upload_fout = "Er is een fout opgetreden tijdens het uploaden.";
$fout_bericht = $upload_fout;
}
// database openen en uploaden
if (!$fout_bericht) {
$aQuery = "INSERT INTO uploads (nieuwnaam,oudnaam,ext,size,type,map)
VALUES ('" . $naam . "',
'" . $files['name'] . "',
'" . $ext . "',
'" . $files['size'] . "',
'" . $soort . "',
'" . $map . "')";
mysql_query($aQuery, $db_connect);
echo "<div>";
echo "Het bestand <b>" . $files['name'] . "
</b> is geupload, in de database gezet en heeft id nummer <b>
" . mysql_insert_id() . "</b> gekregen!<br />";
echo "<a href=" . $_SERVER['PHP_SELF'] . ">Terug naar de index</a>";
echo "</div>";
}
} // einde IF - $_SERVER['REQUEST_METHOD'] == 'POST'
else {
?>
<div>
<form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" enctype="multipart/form-data">
Kies een bestand:
<input type="file" name="upload" /><br/>
<input type="submit" id="Submit" value="Uploaden!" />
</form>
</div>
<?php
}
?>
// controleren of pagina zichzelf heeft aangeroepen
if ($_SERVER['REQUEST_METHOD'] == 'POST') {
// begin de controles
if ($_FILES['upload']['error'] > 0) {
// niet goed verzonden of pagina is foutief aangeroepen
echo "Er is geen bestand geselecteerd om te uploaden!<br />";
// ga een pagina terug
if (isset($_SERVER['REQUEST_URI'])) {
echo "<br />Probeer het <a href=\"" . $_SERVER['REQUEST_URI'] . "\">nogmaals</a>";
}
exit;
}
else {
// een array maken met alle waarden voor de foto
$files = $_FILES['upload'];
}
$type = array(
"ez" => "application/andrew-inset",
"hqx" => "application/mac-binhex40",
"cpt" => "application/mac-compactpro",
"doc" => "application/msword",
"bin" => "application/octet-stream",
"dms" => "application/octet-stream",
"lha" => "application/octet-stream",
"lzh" => "application/octet-stream",
"exe" => "application/octet-stream",
"class" => "application/octet-stream",
"so" => "application/octet-stream",
"dll" => "application/octet-stream",
"oda" => "application/oda",
"pdf" => "application/pdf",
"ai" => "application/postscript",
"eps" => "application/postscript",
"ps" => "application/postscript",
"smi" => "application/smil",
"smil" => "application/smil",
"wbxml" => "application/vnd.wap.wbxml",
"wmlc" => "application/vnd.wap.wmlc",
"wmlsc" => "application/vnd.wap.wmlscriptc",
"bcpio" => "application/x-bcpio",
"vcd" => "application/x-cdlink",
"pgn" => "application/x-chess-pgn",
"cpio" => "application/x-cpio",
"csh" => "application/x-csh",
"dcr" => "application/x-director",
"dir" => "application/x-director",
"dxr" => "application/x-director",
"dvi" => "application/x-dvi",
"spl" => "application/x-futuresplash",
"gtar" => "application/x-gtar",
"hdf" => "application/x-hdf",
"js" => "application/x-javascript",
"skp" => "application/x-koan",
"skd" => "application/x-koan",
"skt" => "application/x-koan",
"skm" => "application/x-koan",
"latex" => "application/x-latex",
"nc" => "application/x-netcdf",
"cdf" => "application/x-netcdf",
"sh" => "application/x-sh",
"shar" => "application/x-shar",
"swf" => "application/x-shockwave-flash",
"sit" => "application/x-stuffit",
"sv4cpio" => "application/x-sv4cpio",
"sv4crc" => "application/x-sv4crc",
"tar" => "application/x-tar",
"tcl" => "application/x-tcl",
"tex" => "application/x-tex",
"texinfo" => "application/x-texinfo",
"texi" => "application/x-texinfo",
"t" => "application/x-troff",
"tr" => "application/x-troff",
"roff" => "application/x-troff",
"man" => "application/x-troff-man",
"me" => "application/x-troff-me",
"ms" => "application/x-troff-ms",
"ustar" => "application/x-ustar",
"src" => "application/x-wais-source",
"xhtml" => "application/xhtml+xml",
"xht" => "application/xhtml+xml",
"zip" => "application/zip",
"au" => "audio/basic",
"snd" => "audio/basic",
"mid" => "audio/midi",
"midi" => "audio/midi",
"kar" => "audio/midi",
"mpga" => "audio/mpeg",
"mp2" => "audio/mpeg",
"mp3" => "audio/mpeg",
"aif" => "audio/x-aiff",
"aiff" => "audio/x-aiff",
"aifc" => "audio/x-aiff",
"m3u" => "audio/x-mpegurl",
"ram" => "audio/x-pn-realaudio",
"rm" => "audio/x-pn-realaudio",
"rpm" => "audio/x-pn-realaudio-plugin",
"ra" => "audio/x-realaudio",
"wav" => "audio/x-wav",
"pdb" => "chemical/x-pdb",
"xyz" => "chemical/x-xyz",
"bmp" => "image/bmp",
"gif" => "image/gif",
"ief" => "image/ief",
"jpeg" => "image/jpeg",
"jpg" => "image/jpeg",
"jpe" => "image/jpeg",
"png" => "image/png",
"tiff" => "image/tiff",
"tif" => "image/tif",
"djvu" => "image/vnd.djvu",
"djv" => "image/vnd.djvu",
"wbmp" => "image/vnd.wap.wbmp",
"ras" => "image/x-cmu-raster",
"pnm" => "image/x-portable-anymap",
"pbm" => "image/x-portable-bitmap",
"pgm" => "image/x-portable-graymap",
"ppm" => "image/x-portable-pixmap",
"rgb" => "image/x-rgb",
"xbm" => "image/x-xbitmap",
"xpm" => "image/x-xpixmap",
"xwd" => "image/x-windowdump",
"igs" => "model/iges",
"iges" => "model/iges",
"msh" => "model/mesh",
"mesh" => "model/mesh",
"silo" => "model/mesh",
"wrl" => "model/vrml",
"vrml" => "model/vrml",
"css" => "text/css",
"html" => "text/html",
"htm" => "text/html",
"asc" => "text/plain",
"txt" => "text/plain",
"rtx" => "text/richtext",
"rtf" => "text/rtf",
"sgml" => "text/sgml",
"sgm" => "text/sgml",
"tsv" => "text/tab-seperated-values",
"wml" => "text/vnd.wap.wml",
"wmls" => "text/vnd.wap.wmlscript",
"etx" => "text/x-setext",
"xml" => "text/xml",
"xsl" => "text/xml",
"mpeg" => "video/mpeg",
"mpg" => "video/mpeg",
"mpe" => "video/mpeg",
"qt" => "video/quicktime",
"mov" => "video/quicktime",
"mxu" => "video/vnd.mpegurl",
"avi" => "video/x-msvideo",
"movie" => "video/x-sgi-movie",
"ice" => "x-conference-xcooltalk"
);
$ext = strtolower(substr(strrchr($files['name'],"."),1));
if(!in_array($ext,$type)) {
$soort = $type[$ext];
}
else {
$soort = "unknown";
}
$map = '/upload/';
$naam = mktime() . "." . $ext;
if (!move_uploaded_file($files['tmp_name'], $_SERVER['DOCUMENT_ROOT'] . $map . $naam)) {
$upload_fout = "Er is een fout opgetreden tijdens het uploaden.";
$fout_bericht = $upload_fout;
}
// database openen en uploaden
if (!$fout_bericht) {
$aQuery = "INSERT INTO uploads (nieuwnaam,oudnaam,ext,size,type,map)
VALUES ('" . $naam . "',
'" . $files['name'] . "',
'" . $ext . "',
'" . $files['size'] . "',
'" . $soort . "',
'" . $map . "')";
mysql_query($aQuery, $db_connect);
echo "<div>";
echo "Het bestand <b>" . $files['name'] . "
</b> is geupload, in de database gezet en heeft id nummer <b>
" . mysql_insert_id() . "</b> gekregen!<br />";
echo "<a href=" . $_SERVER['PHP_SELF'] . ">Terug naar de index</a>";
echo "</div>";
}
} // einde IF - $_SERVER['REQUEST_METHOD'] == 'POST'
else {
?>
<div>
<form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>" enctype="multipart/form-data">
Kies een bestand:
<input type="file" name="upload" /><br/>
<input type="submit" id="Submit" value="Uploaden!" />
</form>
</div>
<?php
}
?>